client: fix i18next config to generate i18n data correctly#511
Open
virusbb001 wants to merge 9 commits intoleanprover-community:mainfrom
Open
client: fix i18next config to generate i18n data correctly#511virusbb001 wants to merge 9 commits intoleanprover-community:mainfrom
virusbb001 wants to merge 9 commits intoleanprover-community:mainfrom
Conversation
Contributor
Author
|
When regenerating for other languages (such as en and de), some translations were lost. This pull request needs to be corrected. |
When I regenerated the translation data, some usable translation data disappeared. Some data seemed incompatible with the new display, and some data, despite being in use, didn't appear to be detected by i18next-scanner. Therefore, it became necessary to set this setting to `false`.
Contributor
Author
|
Since removeUnusedKeys: function(lng, ns, key) {
return lng === "ja";
}I am not familiar with either language, so I have not made any changes that would require changing the values in the translation data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to create JSON data by running
npm run translatein the repository's root directory as per https://github.com/leanprover-community/lean4game/blob/main/doc/translation-interface.md, but instead of being created inclient/public/locales/{language}/translation.jsonas it should have been, it was created as an empty object inclient/client/public/locales/{language}/translation.json. This is because when I ran it withnpm --workspace client,client/became the working directory, and the i18next settings were also treated as relative to that directory.