Skip to content

feat(SetTheory/Cardinal): add cardinality bounds for direct limits - #42125

Open
NoneMore wants to merge 7 commits into
leanprover-community:masterfrom
NoneMore:direct-limit-cardinality
Open

NoneMore wants to merge 7 commits into
leanprover-community:masterfrom
NoneMore:direct-limit-cardinality

Conversation

@NoneMore

@NoneMore NoneMore commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Add an equivalence between a direct limit and its component at an upper-bound index. Use it to prove upper and lower cardinality bounds and criteria for computing the cardinality of direct limits.


AI disclosure: Most declarations, comments, and documentation in this PR were generated with Codex.

Open in Gitpod

@github-actions

github-actions Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

PR summary 12137923ca

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.SetTheory.Cardinal.DirectLimit (new file) 909

Declarations diff (regex)

+ equivOfIsTop
+ mk_eq_iSup_lift_mk
+ mk_eq_of_forall_lift_mk_eq
+ mk_le_of_aleph0_le
+ mk_le_sum

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit 1213792).

  • +5 new declarations
  • −0 removed declarations
+DirectLimit.equivOfIsTop
+DirectLimit.mk_eq_iSup_lift_mk
+DirectLimit.mk_eq_of_forall_lift_mk_eq
+DirectLimit.mk_le_of_aleph0_le
+DirectLimit.mk_le_sum

No changes to strong technical debt.

Increase in weak tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (weak)
5127 1 exposed public sections

Current commit 12137923ca
Reference commit 40d045ae49

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger

Copy link
Copy Markdown
Contributor

LLM-generated

@github-actions github-actions Bot added the LLM-generated PRs with substantial input from LLMs - review accordingly label Jul 27, 2026
@joneugster joneugster added the t-set-theory Set theory label Sep 20, 2026
@mathlib-triage mathlib-triage Bot assigned YaelDillies and unassigned alreadydone Oct 26, 2026
Comment thread Mathlib/Order/DirectedInverseSystem.lean Outdated
Comment thread Mathlib/Order/DirectedInverseSystem.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/DirectLimit.lean Outdated
Comment thread Mathlib/SetTheory/Cardinal/DirectLimit.lean Outdated
@YaelDillies YaelDillies added the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Oct 28, 2026
@NoneMore

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

@NoneMore

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Oct 28, 2026
NoneMore added a commit to NoneMore/mathlib4 that referenced this pull request Oct 28, 2026
NoneMore added a commit to NoneMore/mathlib4 that referenced this pull request Oct 28, 2026
NoneMore added a commit to NoneMore/mathlib4 that referenced this pull request Oct 28, 2026
NoneMore added a commit to NoneMore/mathlib4 that referenced this pull request Oct 28, 2026

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

Comment thread Mathlib/SetTheory/Cardinal/DirectLimit.lean Outdated
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 28, 2026
@YaelDillies YaelDillies removed their assignment Oct 28, 2026
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants