Repository navigation
Conversation
PR summary 68ac51c9b7Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
grunweg
left a comment
There was a problem hiding this comment.
Two small comments. The change to Mathlib/Util/GetAllModules.lean LGTM already.
| /-- Which libraries of the current package should always be excluded from `mk_all`. -/ | ||
| excludedLibs : Array Name := #[] | ||
| /-- Modules (like `Mathlib.Tactic`) which are not roots of any `lean_lib`, but should be treated | ||
| like one. Assumes that the folder they draw their imports from is located at the same path but |
There was a problem hiding this comment.
This comment is not yet clear to me.
There was a problem hiding this comment.
Specifically the folder path bit? If so, is something like
Assumes that (as with
lean_libroots) the folder from which the given module should import is adjacent to the module, e.g.mathlib4/Mathlib/Tactic.leanimports the modules inmathlib4/Mathlib/Tactic/.
clearer? Or, is the issue the whole thing? (Tentatively changed.)
|
This PR/issue depends on:
|
This PR revamps
mk_alltolean_libs and rely on more robust Lake API more broadlyConfiginternally that accounts for the mathlib-specific exceptions, so that in the future downstream projects could read this from json instead--clobberto do so--lib Foo,Bar,BazThis also generally refactors the code somewhat to make it more principled and (hopefully) maintainable.
We also change the behavior of API in
Mathlib.Util.GetAllModulesas appropriate in order to rely on more robust paths.docs#45107