Repository navigation
Conversation
PR summary 30164500bbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
6923916 to
3016450
Compare
grunweg
left a comment
There was a problem hiding this comment.
Thanks for adding both versions. This begs the question: can these be unified, perhaps using to_dual on one of the statements? (The duplication is not too bad, so I would be fine with merging them as-is, but if we can avoid it, of course we should.)
|
@grunweg I don't think -awaiting-author |
|
I see. Sounds like it would be scope creep then. This time, I'd appreciate a close look by somebody who knows this corner of the library better than me! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
tb65536
left a comment
There was a problem hiding this comment.
These seem like better lemmas to me.
|
Thanks! bors merge |
#45408) The previous statement mixed left and right multiplication, so it required `CommGroup`. It also used `smul`/`vadd` for no reason (other than that fitting better in the original application it was made for). This splits it into left and right versions not assuming commutativity, and uses `mul`/`add`. Also moves it to a better place in the file.
|
Pull request successfully merged into master. Build succeeded: |
The previous statement mixed left and right multiplication, so it required
CommGroup. It also usedsmul/vaddfor no reason (other than that fitting better in the original application it was made for).This splits it into left and right versions not assuming commutativity, and uses
mul/add.Also moves it to a better place in the file.
The previous version came from an automated split #45380, and the original file was a draft.