Skip to content

Switch to 3rdparty action for clang-tidy run #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aobolensk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Switch to 3rdparty action for clang-tidy run #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 0 additions & 114 deletions .github/actions/clang-tidy-native/action.yml
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions .github/workflows/static-analysis-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,10 @@ jobs:
- name: Show ccache stats
run: ccache --show-stats
- name: Run clang-tidy
uses: ./.github/actions/clang-tidy-native
id: review
uses: aobolensk/clang-tidy-action@1685ada95cfee180d12944c3401ea33580d1d4e9
with:
exclude: "3rdparty build"
clang_tidy_version: "21"
- if: steps.review.outputs.total_comments > 0
run: |
echo "clang-tidy run has failed. See previous 'Run clang-tidy' stage logs"
exit 1
clang-tidy-for-gcc-build:
needs:
- clang-tidy
Expand Down Expand Up @@ -111,15 +106,10 @@ jobs:
- name: Show ccache stats
run: ccache --show-stats
- name: Run clang-tidy
uses: ./.github/actions/clang-tidy-native
id: review
uses: aobolensk/clang-tidy-action@1685ada95cfee180d12944c3401ea33580d1d4e9
with:
exclude: "3rdparty build docs_venv .git .pytest_cache .ruff_cache xml"
clang_tidy_version: "21"
- if: steps.review.outputs.total_comments > 0
run: |
echo "clang-tidy run has failed. See previous 'Run clang-tidy' stage logs"
exit 1
nolint-check:
runs-on: ubuntu-24.04
steps:
Expand Down
2 changes: 1 addition & 1 deletion modules/task/include/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class Task {
const auto max_time = ppc::util::GetTaskMaxTime();
std::stringstream err_msg;
if (diff < max_time) {
err_msg << "Test time:" << std::fixed << std::setprecision(10) << diff << '\n';
err_msg << "Test time:" << std::fixed << std::setprecision(10) << diff << std::endl;
} else {
err_msg << "\nTask execute time need to be: ";
err_msg << "time < " << max_time << " secs.\n";
Expand Down
Loading