Support of ordering versionable and repeatable migrations.#177
Open
ssoloshchak wants to merge 2 commits intolecaillon:masterfrom
Open
Support of ordering versionable and repeatable migrations.#177ssoloshchak wants to merge 2 commits intolecaillon:masterfrom
ssoloshchak wants to merge 2 commits intolecaillon:masterfrom
Conversation
Author
|
Hey there, could you please either review or reject PR? |
|
I think this is not the approach to follow. Maybe the repeatable order should go with a version number or a prefix to support some kind of setup/cleanup flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very nice that library provide versionable and repeatable types of migration files. But sometimes it might be useful to be able to apply repeatable migrations in before versionable. Could you please approve.