style(banner): match reference artwork with layered additive gold caption - #21
Merged
Merged
Conversation
leochiu-a
force-pushed
the
style/banner-caption-additive-sheen
branch
from
July 17, 2026 13:51
d035320 to
18298d9
Compare
…tion Rework the canvas caption to reproduce the image-creator's Elden "Victory" look on GitHub's dark theme: a deep matte gold face (220,175,45) with the warm ghost (255,208,66 @ 0.18) stacked on top and blended additively via mix-blend-mode:plus-lighter (fallback screen). Where the ghost aligns over the face it adds to it — the bright overlap tone (~255,213,57); where it spreads it becomes the dim offset echo, so overlapping text shows a real blended colour instead of flat gold. The ghost stays a separate layer (band -> caption -> sheen) so its outward spread (scaleX -> 1.11) animates after the fade-in. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
leochiu-a
force-pushed
the
style/banner-caption-additive-sheen
branch
from
July 17, 2026 13:54
18298d9 to
3f555cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rework the canvas-rendered approved/victory banner caption so it reproduces the image-creator's Elden "Victory" look on GitHub's dark theme, matching the reference banner artwork in
src/assets/*.png.The caption is two layers:
220,175,45, a single clean opaque pass.255,208,66@0.18, stacked on top of the face and blended additively viamix-blend-mode: plus-lighter(falling back toscreen).Where the sheen aligns over the face it adds to it — the bright overlap tone (
~255,213,57); where it spreads past the letters it becomes the dim offset echo. So overlapping text shows a real blended colour (the layered-gold look) instead of flat gold. The sheen stays a separate layer (stacking orderband → caption → sheen) so its outward spread (scaleX → 1.11) can animate after the fade-in.Why
The old caption read wrong on GitHub's dark theme (variously too dark, too bright, or flat). Root causes found along the way:
screencan't reproduce that additive brightening;plus-lighter(true additive) can, and renders correctly in Chrome.Changes
eldenBanner.ts— face = single opaque deep gold; sheen = additive ghost255,208,66 @ 0.18.banner.ts— layer orderband → caption → sheen(sheen on top).styles.css—.banner-sheenusesmix-blend-mode: plus-lighter(fallbackscreen); animated spread widened toscaleX(1.11).*.test.ts— updated the caption pass-count and the layer-order assertion (sheen now follows caption).Test plan
vitest run src/content/eldenBanner.test.ts— passnpm run build— succeedsdist/as an unpacked extension and confirm on a real GitHub PRKnown limitation
The reference art uses Agmena Pro (Adobe Typekit), which the extension doesn't bundle, so it falls back to Georgia — slightly different letterforms. Bundling a close free serif could narrow this in a separate change.
🤖 Generated with Claude Code