[robertn702]

Summary

• Fail with a clear error when no Anki profile or sync key is available.
• Read the collection sync response and handle required full downloads, uploads, and conflicts.
• Use a redirected sync endpoint for the remaining collection and media work.
• Print server messages instead of discarding them.

Safety

Full uploads and downloads require confirmation. Downloads create and await a local backup before replacing the collection. The collection is reopened after a failed full transfer and closed if automatic sync aborts.

Tests

• uv run ruff format --check
• uv run ruff check
• uv run pyrefly check --baseline pyrefly-baseline.json
• uv run pytest (38 passed)
• git diff --check

Closes #159

[lervag]

Thanks, I appreciate the PR, it addresses a real bug!

On tests/test_sync.py: Thanks for adding these. I'd like to redirect the effort though, because as written they don't constrain much.

The tests construct the object under test with Anki.__new__(Anki) and assign _profile and col by hand, then assert exact call sequences against a hand-written FakeCollection. That describes the implementation rather than the behaviour: assert collection.operations == [("normal", True), ("backup", ...), ("close", None), ...] breaks on any harmless reordering, while real defects pass straight through. There are two real defects in this PR that passes all seven tests:

1. The confirmation prompt is never visible. It's issued inside the live Progress block, so rich erases it on the next refresh (~100ms). Under a pty you get a spinner and an apparently hung program. Pressing Enter takes the default and aborts. The tests can't see this because console.confirm is monkeypatched away. That is, the test substitutes exactly the part that's broken.

2. sync() now raises Abort with no profile or sync key, which __exit__ reaches via auto_sync. With "auto_sync": true in ~/.config/apy/apy.json, this branch has 25 failed tests. CI missed it because CI has no apy.json config. And yes, this is a pre-existing gap in the test setup which I'll fix separately.

What I'd find more valuable:

• Keep the behavioural tests and drop the sequence ones. test_sync_without_key_fails_instead_of_reporting_success and test_sync_conflict_can_be_cancelled encode the actual promise of #159 and are worth having. For the rest, the membership style you already used in test_sync_uploads_when_only_full_upload_is_allowed (assert ("full", ...) in collection.operations) says what matters without freezing the call order.
• For real coverage, anki ships a sync server: SYNC_BASE=... SYNC_USER1=user:pass python -m anki.syncserver. I checked, it starts and listens on a local port. A fixture that spawns it would let you drive the exact scenario in the issue through the real backend, with no fake to keep in sync with anki's API.

I'll let the second "real coverage" item be optional here, since I can understand it may feel like a larger task. But if you want, feel free to address it.

[robertn702]

@lervag Thanks for the thorough review! I'll get around to updating the PR in the next few days.

[lervag]

@lervag Thanks for the thorough review! I'll get around to updating the PR in the next few days.

I see you've pushed some updates now; let me know when you want me to take another look. And don't hesitate to ask for input or assistance!

[robertn702]

Sorry for the delay. Rebased onto master and pushed the changes from your review. Auto-sync without a profile or sync key now prints a warning and skips the sync, and only an explicit apy sync errors. The prompts pause the progress display, and I checked in a real terminal that the prompt and the answer stay on screen. An unexpected NORMAL_SYNC aborts, and the currentSyncUrl write is gone.

I also took your suggestion to test against anki.syncserver. tests/test_sync_server.py runs the download, upload and conflict cases through the real backend, and all four tests fail on master. I cut tests/test_sync.py down to the cases the server can't easily trigger and replaced the call-order checks with behaviour checks.

Ready for another look when you have time.

[lervag]

Great, thanks! And thanks for the nice contribution!