Fix dashboard favicon serving#85
Merged
Merged
Conversation
letsrokk
marked this pull request as ready for review
July 20, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public/directory in the Docker build stage so Vite can copyfavicon.svgintodist/__fleet/favicon.svgso the favicon is served as a static file instead of falling through to the SPA shellRoot Cause
The deployed dashboard image was built without
fleet-dash/public/, sodist/favicon.svgwas absent inside the image. Requests to/__fleet/favicon.svgthen hit the SPA fallback and returnedindex.html.Verification
npm run buildinfleet-dashnpm test -- --runinfleet-dashdocker build -t mock-fleet-dash:favicon-fix .infleet-dashcurl -i http://localhost:18080/__fleet/favicon.svgreturns200 OKwithContent-Type: image/svg+xml