fix(skills): correct built-in command override guidance in customizing-commands - #4120
Draft
amelia-letta wants to merge 1 commit into
Draft
fix(skills): correct built-in command override guidance in customizing-commands#4120amelia-letta wants to merge 1 commit into
amelia-letta wants to merge 1 commit into
Conversation
…g-commands The skill said "Do not register built-in command IDs" but the mod engine allows it: registering a built-in command ID records a warning diagnostic (phase: command_override, severity: warning) and the command still registers, shadowing the built-in. The skill reference file commands.md says built-in commands can be overridden by trusted local mods. Align the rule with the source code and the reference. Builtin-skill-watch: customizing-commands@852ca244b002-75330c920320721f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin-skill-watch: customizing-commands@852ca244b002-75330c920320721f
Selected skill:
customizing-commandsStale claim
The skill's Rules section said:
Current owning source
src/mods/mod-engine.ts(lines 1113-1126): when a mod command ID matches a built-in command ID, the engine records a diagnostic with phasecommand_overrideand severitywarning(viagetModDiagnosticSeverityinsrc/mods/mod-diagnostics.ts:44). The command still registers and shadows the built-in.The skill's own reference file
src/skills/builtin/creating-mods/references/commands.mdsays:Fix
Replaced the rule with guidance that matches the source code and the reference:
Validation
bun run check(12/12 checks passed)bun test src/cli/mods/command-runtime.test.ts(4 pass)bun test src/mods/mod-engine.test.ts(38 pass)