Repository navigation
test: verify public repository OCR review - #1
Open
zehongye-gaga wants to merge 3 commits into
Open
zehongye-gaga wants to merge 3 commits into
zehongye-gaga wants to merge 3 commits into
Conversation
Collaborator
Author
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
Reviewed |
zehongye-gaga
commented
Oct 26, 2026
|
|
||
| def average(values): | ||
| """Return the arithmetic mean, or zero for an empty collection.""" | ||
| return sum(values) / len(values) |
Collaborator
Author
There was a problem hiding this comment.
average([]) raises ZeroDivisionError because len(values) is zero, rather than returning the documented zero. Handle the empty collection before dividing.
Suggestion:
Suggested change
| return sum(values) / len(values) | |
| if len(values) == 0: | |
| return 0 | |
| return sum(values) / len(values) |
|
|
||
| def first_or_none(values): | ||
| """Return the first value, or None if the collection is empty.""" | ||
| return values[0] |
There was a problem hiding this comment.
first_or_none([]) raises IndexError instead of returning the promised None, because index 0 is accessed unconditionally. Handle the empty sequence before indexing, and add a regression test for empty input.
Suggestion:
Suggested change
| return values[0] | |
| return values[0] if values else None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small integration test for the public repository review pipeline. Adds a six-line, non-production Python fixture with an intentional empty-input boundary bug so we can verify review findings as well as dispatch. Please leave this PR open during verification; it is not intended for production use.