Repository navigation
test: production control-plane rollout end to end - #14
Open
zehongye-gaga wants to merge 2 commits into
Open
zehongye-gaga wants to merge 2 commits into
zehongye-gaga wants to merge 2 commits into
Conversation
![lexmount-ocr[bot]](https://avatars.githubusercontent.com/u/277637559?s=60&v=4){kind=small}
There was a problem hiding this comment.
This review found 1 issue(s), including 1 blocking issue(s).
|
|
||
| def bounded_average(values): | ||
| """Return zero for empty input and the arithmetic mean otherwise.""" | ||
| return sum(values) / len(values) |
There was a problem hiding this comment.
Blocking: bounded_average([]) raises ZeroDivisionError because len(values) is zero, instead of returning zero as documented. Handle the empty input before dividing and add a regression test asserting bounded_average([]) == 0.
Suggestion:
Suggested change
| return sum(values) / len(values) | |
| if len(values) == 0: | |
| return 0 | |
| return sum(values) / len(values) |
There was a problem hiding this comment.
✅ Re-review complete · eaeb699
No findings in this incremental review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production rollout validation for the backend-owned OCR control plane, public Policy workflow, and published Github-CI n8n gateway.
This disposable fixture intentionally violates its documented empty-input behavior so the real Agent/native OCR should publish a blocking finding. A follow-up commit will correct the fixture to verify a new snapshot is reviewed independently. Do not merge this test branch.
Validation follows actual GitHub App and organization CI ingress, durable admission, Agent dispatch, native OCR, publication, and deduplication. AI disclosure: created with OpenAI Codex (GPT-6).