Skip to content

test: native stacked OCR review — upper layer before parent merge #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zehongye-gaga wants to merge 1 commit into from
Open

test: native stacked OCR review — upper layer before parent merge #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions stacked_weighted_probe_20261101.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
"""Dependent layer for the isolated stacked PR review fixture."""

from stacked_probe_20261101 import average


def weighted_average(values, weights=None):
"""Return the weighted mean, or 0 when the total weight is zero."""
if weights is None:
return average(values)
if len(values) != len(weights):
raise ValueError("values and weights must have the same length")
return sum(value * weight for value, weight in zip(values, weights)) / sum(weights)

@lexmount-ocr lexmount-ocr Bot Nov 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug · medium
A zero total weight raises ZeroDivisionError instead of returning the promised 0. For example, weighted_average([10], [0]) and weighted_average([], []) both reach this division with a zero denominator. Compute the total weight first and return 0 when it is zero, preserving the existing None fallback and length validation.

Suggestion:

Suggested change
return sum(value * weight for value, weight in zip(values, weights)) / sum(weights)
total_weight = sum(weights)
if total_weight == 0:
return 0
return sum(value * weight for value, weight in zip(values, weights)) / total_weight

Loading