Skip to content

test: verify custom repository rules through OCR - #7

Open
zehongye-gaga wants to merge 3 commits into
mainfrom
test/custom-review-rule-proof-20261027
Open

zehongye-gaga wants to merge 3 commits into
mainfrom
test/custom-review-rule-proof-20261027

Conversation

@zehongye-gaga

Copy link
Copy Markdown
Collaborator

Isolated integration fixture for repository-specific review rules. The base branch contains a scoped rule for this file. Round one intentionally violates that contract; round two will correct it to verify incremental re-review. No production code or platform configuration is changed. Created with OpenAI Codex assistance. Leave this PR unmerged after verification.

@lexmount-ocr lexmount-ocr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Review skipped · 7937c3b

No reviewable content was selected for this run.

@zehongye-gaga
zehongye-gaga force-pushed the test/custom-review-rule-proof-20261027 branch from 7937c3b to ee825a5 Compare October 27, 2026 02:36

@lexmount-ocr lexmount-ocr Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Review complete · ee825a5

This review found 1 issue(s), including 1 blocking issue(s).

Comment thread src/custom_rule_demo.py Outdated


def exported_job_name() -> str:
return "daily_report"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug · medium
OCR-CUSTOM-RULE-TEST-20261027: The returned job name "daily_report" lacks the required "ocr_" prefix, so the test consumer will reject it. Preserve the name while adding the required prefix: "ocr_daily_report".

Suggestion:

Suggested change
return "daily_report"
return "ocr_daily_report"

@zehongye-gaga
zehongye-gaga force-pushed the test/custom-review-rule-proof-20261027 branch from ee825a5 to 4803506 Compare October 27, 2026 02:37

@lexmount-ocr lexmount-ocr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Review complete · 4803506

This review found 1 issue(s), including 1 blocking issue(s).


ℹ️ All inline comments overlapped with existing reviews; nothing new was posted.

@lexmount-ocr lexmount-ocr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Re-review complete · 1d21f6b

No findings in this incremental review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant