Repository navigation
feat: emit structured Policy ACK telemetry - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add versioned
ocr-policy-telemetry/v1JSON lines to the existing Actions log so the independent audit Worker can distinguish valid ACKs, policy skips, final ACK deadline expiry and other failures, and associate them with a PR snapshot and run attempt.The client emits request timing and one final result, without a reporting HTTP request, new secret, dependency or workflow permission. Preserve the existing submission endpoints, 90-second wall deadline, four HTTP attempts and exit behavior. Credentials and response bodies remain excluded. Regenerate the embedded workflow from the tested client.
Validation:
python3 ocr/render_workflow.pyandpython3 -m unittest discover -s ocr -qpassed (30 tests), plusgit diff --check. The actual client output also passed a local cross-repository simulated Actions -> independent Worker -> PostgreSQL -> authenticated ReviewHub API test, covering timeout alongside durable acceptance, reruns, deduplication, failed transactions and restart.Platform companion: https://github.com/zehongye-gaga/ReviewHub/pull/6. The Worker pulls completed logs; missing or cancelled runs remain unknown/cancelled, not inferred timeouts. Existing historical logs do not gain final results retroactively. Production publication and a real target-repository run are still required; this PR changes no Ruleset or secret.
AI assistance: implemented and locally reviewed with OpenAI Codex (GPT-6).
Companion changes: ReviewHub https://github.com/zehongye-gaga/ReviewHub/pull/6; collector zehongye-gaga/open-code-review#30 (stacked on zehongye-gaga/open-code-review#28); private Policy https://github.com/lexmount/github-policy/pull/27; public Policy #5.