Conversation
Add return/param type hints to _pack_parts, _unpack, _sendall_vectored, and use_key. Pure annotations, no behavior change. - _pack_parts() -> list[bytes | memoryview] - _unpack(buf: bytes | bytearray | memoryview) - _sendall_vectored(parts: list[bytes | memoryview]) - use_key(material: None)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First contribution here
I added type hints to four functions in
shard/transport.pythatwere missing them, so the wire format is visible at a glance without
tracing through the body:
_pack_parts()now declares it returnslist[bytes | memoryview]_unpack()declares its input isbytes | bytearray | memoryview_sendall_vectored(parts=...)declareslist[bytes | memoryview]use_key()declaresmaterial: NoneThis is pure annotation work — no behavior changes, no extra imports.
Kept the changes minimal and matched the existing style.
Tests:
test_transport_vectored.py+test_wire_hardening.py→ 38 passed.Happy to adjust anything if it doesn't fit the maintainers' preferences