Repository navigation
fix(sidebar): share compact rows and drag feedback - #1713
Merged
Merged
Conversation
Use insertion gaps as the pinned-row spacing and show directional feedback for compatible built-in and pinned reorders. Keep the active indicator above the general file-drop outline while retaining folder-body transfers and spring navigation. Refs #1707
JoeJoeflyn
marked this pull request as ready for review
October 16, 2026 15:46
Reuse row gaps, reorder targets and hover ownership across Places, Pinned, Devices and picker sidebars. Preserve local-only picker filtering and prevent stale drop/focus indicators.\n\nRefs #1707
Contributor
ReviewNo merge blockers found. No commits pushed: the head ( What I checked
Scope note (not blocking): besides gap spacing, the picker sidebar now has the full place/pin behavior: reordering, drag-to-pin, and the Unpin/Customize…/Properties context menu. Unpinning Home or an XDG place there hides it everywhere, because it writes the shared preference. Local verification (native, private headless display/bus)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compact pinned sidebar rows by using the insertion gaps as the spacing instead of adding spacing around each gap. Show clear before/after reorder lines for both built-in places and pins, without letting the general file-drop outline override them. Folder-body transfers and spring navigation remain unchanged.
Visual evidence
screenrecording-2026-10-16_22-48-30.mp4
How to test
Expected result: Compact rows, clear accent insertion lines at the intended position, persistent reordering, and unchanged file transfers onto folder bodies. Built-in places and pins cannot reorder into each other's section.
Related issue
Closes #1707