Skip to content

hddtemp2: check if disk is a valid device and fix model name for smartctl #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazy-max wants to merge 3 commits into
base: master
Choose a base branch
from
Open

hddtemp2: check if disk is a valid device and fix model name for smartctl #583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ea6307
hddtemp2: check if disk is a valid device
crazy-max Aug 21, 2025
a5765f7
hddtemp2: fix model name for smartctl
crazy-max Aug 21, 2025
f91158e
hddtemp2: fix perms
crazy-max Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions agent-local/hddtemp2
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Name: hddtemp2
# Author: Jason Cheng (www.jason.tools)
# Date: 2025-02-17
# Version: 1.1
# Version: 1.2
# Purpose: This script replaces the obsolete hddtemp tool for librenms agent to monitor disk temperatures
# License: Free Software

Expand All @@ -26,25 +26,28 @@ if [ "${smartctl}" != "" ]; then
for disk in $disks; do
# Exclude non-physical disks like RBD (RADOS Block Device)
if [[ ! "$disk" =~ rbd ]]; then
# Get disk model first
model=$(${smartctl} -i $disk | grep 'Device Model' | cut -d':' -f2 | sed 's/^\s*//g')

# Try different temperature attributes in order of preference
# First try Airflow_Temperature_Cel
temp_info=$(${smartctl} -A $disk | grep 'Airflow_Temperature_Cel' | awk '{print $10}')
# Check if the disk is a valid device
if ${smartctl} -i "$disk" > /dev/null 2>&1; then
# Get disk model first
model=$(${smartctl} -i $disk | grep 'Device Model' | cut -d':' -f2 | tr -d '[:space:]$')

# If not found, try Temperature_Celsius
if [ -z "$temp_info" ]; then
temp_info=$(${smartctl} -A $disk | grep 'Temperature_Celsius' | awk '{print $10}')
fi
# Try different temperature attributes in order of preference
# First try Airflow_Temperature_Cel
temp_info=$(${smartctl} -A $disk | grep 'Airflow_Temperature_Cel' | awk '{print $10}')

# If still not found, try Drive_Temperature
if [ -z "$temp_info" ]; then
temp_info=$(${smartctl} -A $disk | grep 'Drive_Temperature' | awk '{print $4}')
fi
# If not found, try Temperature_Celsius
if [ -z "$temp_info" ]; then
temp_info=$(${smartctl} -A $disk | grep 'Temperature_Celsius' | awk '{print $10}')
fi

# Format output regardless of which temperature was found
output="${output}|${disk}|${model}|${temp_info}|C|"
# If still not found, try Drive_Temperature
if [ -z "$temp_info" ]; then
temp_info=$(${smartctl} -A $disk | grep 'Drive_Temperature' | awk '{print $4}')
fi

# Format output regardless of which temperature was found
output="${output}|${disk}|${model}|${temp_info}|C|"
fi
fi
done
# Clean output, keep only printable characters
Expand Down