Remove redundant closures #1655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photovoltex
approved these changes
Dec 3, 2025
Member
photovoltex
left a comment
photovoltex
left a comment
There was a problem hiding this comment.
LGTM. But just out of curiosity... why the change? Were there any reports that the other way doesn't work? Or did they update a clippy rule, or any other reason behind the changes?
Don't get me wrong, they seem fine and all, but they don't bring any improvement with them I think? So the curiosity wants to know what brought you to make these changes^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for closures which only invoke a method on the closure argument and can be replaced by referencing the method directly.
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls