Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle absolute CMake install directories in libtommath.pc while preserving the existing prefix-relative form for relative directories.
With BUILD_SHARED_LIBS=ON and an absolute CMAKE_INSTALL_INCLUDEDIR or CMAKE_INSTALL_LIBDIR, installation already places files in the requested directory. The current pkg-config template nevertheless prepends
${prefix}/, producing include/library paths that do not exist. An installed consumer fails to find tommath.h, or fails to link -ltommath when only the library directory is absolute.The fix computes each pkg-config directory independently. The shared Makefile also uses this template, so its substitutions are updated to preserve its existing byte-for-byte output.
Tests
Tested on Linux x86-64 with GCC 14.2.0, CMake 3.31.6 and pkg-config 1.8.1. Full libtool builds and other platforms were not run.