-
Notifications
You must be signed in to change notification settings - Fork 457
RFC: Hotplug implementation #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Youw
wants to merge
13
commits into
master
Choose a base branch
from
connection-callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,395
−158
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1b0b6ac
hotplug: Add ability to register device connection/disconnection call…
DJm00n 79a3516
Merge branch 'master' into connection-callback
Youw ce92386
Windows hotplug: Mutex for callback actions (#646)
k1-801 c3a2775
Connection callback: add stubs for netbsd (#668)
k1-801 60b40d9
Linux Hotplug: connection-callback implementation for libusb backend …
k1-801 4537833
Linux Hotplug: Connection-callback implementation for hidraw (#647)
k1-801 4f73d1f
Hotplug implementation for MacOS (HidManager approach) (#653)
k1-801 cfed154
Merge branch 'master' into connection-callback
Youw b6606ca
Connection callback: fix LeaveCriticalSection not being called after …
d3xMachina da500c6
Fix possible deadlock in Connection-callback feature (#676)
k1-801 19112a2
Merge branch 'master' into connection-callback
Youw ec2cd2f
Merge branch 'master' into connection-callback
Youw 12a30f1
Merge branch 'master' into connection-callback
Youw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation says it is safe to call
hid_hotplug_deregister_callback()on an already deregistered callback. However, current backend implementations return -1 when the callback list is empty / not initialized, which contradicts that contract. Either adjust the implementations to treat “not found / already removed” as success (return 0), or update this documentation to match the actual behavior.