chore(skills): add create-pr skill

[mirooon]

Which Linear task belongs to this PR?

Why did I implement it this way?

Adds a create-pr Claude Code skill that automates branch → commit → push → PR. The skill:

• reads .github/pull_request_template.md verbatim and fills only specific named fields (Linear link, rationale, ticked checkboxes);
• resolves a Linear link from conversation context, falling back to the Linear MCP, and asks the user in chat (with a skip option) if neither finds a match — never fabricates;
• verifies before ticking the author checklist: walks git diff main...HEAD for the self-review tick; inspects git log main..HEAD --oneline for the single-concern tick;
• runs the test suite (forge test / bun test:ts) — the gap .husky/pre-commit deliberately leaves (the hook uses forge build --skip test and doesn't invoke bun test:ts). Lint / typecheck / build / solhint / secret scan are already enforced by pre-commit + .agents/hooks/post-edit-validate.sh, so the skill does not duplicate them;
• delegates to the /pr-ready sibling skill for local CodeRabbit pre-flight (mandatory per .agents/rules/099-finish.md once chore(skills): add /pr-ready local CodeRabbit pre-flight #1792 lands), and appends a ## /pr-ready deferred findings section to the body when items are deferred/rejected;
• handles edge cases at step 1: no changes / detached HEAD / on main with local changes / branch already has an open PR;
• shows a pre-flight summary (self-review findings, check statuses, full filled-in body, /pr-ready commits added) and waits for explicit y/n before pushing;
• leaves the reviewer checklist unchecked and offers to post the PR to #dev-sc-review via /post-pr-for-review.

Aikido findings reviewed: two findings on the skill file (template-read at line 72; Linear MCP at line 76) — both reviewed as false positives. The PR template is a checked-in public file with no secrets; .husky/pre-commit scans for secrets + private keys before any commit lands (step 4); the step 9 pre-flight summary requires explicit y/n before push. Linear is the team's own authenticated ticket tracker via MCP — not a third-party data sink — and branch/commit text becomes publicly visible at git push to this public repo seconds later anyway.

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

Adds a detailed .agents/commands/create-pr.md specification for a 12-step create-pr workflow, reorders one global-rules bullet, adds MCP tool naming guidance, and replaces embedded skill docs with redirects to the new command spec.

Changes

Create PR Skill Workflow

Layer / File(s)	Summary
Global rules activation and MCP naming .agents/rules/000-global-standards.md, .agents/commands/add-new-rule.md	Repositions the “Uncertainty” guidance and adds a “Referencing MCP Tools” section requiring client-agnostic MCP tool names instead of fully-qualified runtime IDs.
Skill metadata, triggers, and redirects .agents/commands/create-pr.md, .claude/skills/create-pr/SKILL.md, .cursor/commands/create-pr.md	Introduces create-pr metadata and triggers; replaces embedded skill files with single-line forwards to the canonical .agents/commands/create-pr.md.
Repository state assessment & branch naming .agents/commands/create-pr.md	Defines git-state checks (clean tree, detached HEAD, existing PRs, protected main/master) and branch-name derivation rules prioritizing Linear IDs and avoiding protected branches.
Branch creation, staging, and commit conventions .agents/commands/create-pr.md	Create/switch branch when needed, stage only task-relevant files, and derive a concise, imperative commit subject.
PR body construction and Linear resolution .agents/commands/create-pr.md	Build PR body from the local template, resolve or create Linear tasks with explicit consent, populate rationale and author checklist, and handle ambiguity prompting and branch-rename behavior.
PR title, /pr-ready integration, and test execution .agents/commands/create-pr.md	Derive PR title, require running /pr-ready (stop on errors), append deferred findings, select and run appropriate tests for the change type, and stop on failing checks.
Pre-flight confirmation, push, and PR creation .agents/commands/create-pr.md	Render a pre-flight summary (commits, files, checks, self-review), require explicit user confirmation, push the branch, run gh pr create using main as base, print the PR URL, and offer /post-pr-for-review.
Failure modes and operational notes .agents/commands/create-pr.md	Enumerates failure modes (secrets, existing PRs, push rejections, missing template, unknown Linear task, test or /pr-ready failures) and adds final notes about unrelated files and not amending published commits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• lifinance/contracts#1780: Adds post-pr-for-review skill/docs which the create-pr skill references as a post-creation action.
• lifinance/contracts#1792: Introduces the /pr-ready command/docs that create-pr uses as a mandatory pre-flight gate.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore(skills): add create-pr skill' accurately summarizes the main change: adding a new create-pr skill to the codebase.
Description check	✅ Passed	The PR description covers the required template sections: Linear task status, implementation rationale with detailed technical decisions, and a mostly-completed author checklist. One required checkbox is missing but the core required sections are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/add-create-pr-skill

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

.claude/skills/create-pr/SKILL.md (1)

149-181: 💤 Low value

Consider adding language specifier to code block.

The fenced code block at line 149 lacks a language specifier. While not critical, adding text or markdown would improve rendering consistency and satisfy the markdownlint MD040 rule.

📝 Proposed fix

-```
+```text
 About to create PR on branch `<branch-name>`:

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/skills/create-pr/SKILL.md around lines 149 - 181, The fenced code
block that begins with "About to create PR on branch `<branch-name>`" is missing
a language specifier; update that block delimiter from ``` to ```text (or
```markdown) so the block starts with ```text and the rest of the content
remains unchanged, which will satisfy MD040 and improve rendering consistency.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/create-pr/SKILL.md:
- Line 29: The step number in the sentence referencing "/pr-ready" is incorrect:
it says "/pr-ready is integrated as step 8" but the workflow lists "/pr-ready"
as step 7 and the test suite as step 8; update the text in SKILL.md to refer to
"/pr-ready" as step 7 (or reword to avoid a hardcoded step number) so it matches
the actual workflow ordering and prevents confusion (search for the phrase
"/pr-ready is integrated as step 8" and change "step 8" to "step 7" or use a
non-numbered description).

---

Nitpick comments:
In @.claude/skills/create-pr/SKILL.md:
- Around line 149-181: The fenced code block that begins with "About to create
PR on branch `<branch-name>`" is missing a language specifier; update that block
delimiter from ``` to ```text (or ```markdown) so the block starts with ```text
and the rest of the content remains unchanged, which will satisfy MD040 and
improve rendering consistency.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 875bc1f8-2c17-46a2-9b4b-d14b8128252c

📥 Commits

Reviewing files that changed from the base of the PR and between 3ced1b8 and 5b62929.

📒 Files selected for processing (1)

• .claude/skills/create-pr/SKILL.md

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.agents/commands/create-pr.md:
- Line 210: Replace the hardcoded temporary file usage in the gh pr create
invocation by generating a unique temp file with mktemp, write the PR body into
that temp file, call gh pr create using --body-file to point to the temp file
(instead of command substitution with cat /tmp/pr-body.md), and ensure the temp
file is removed after the command (trap or explicit rm); update the command
referenced (gh pr create --body "$(cat /tmp/pr-body.md)") to use the
mktemp-created path and --body-file to avoid race conditions and ensure cleanup.

In @.cursor/commands/create-pr.md:
- Line 1: The file .cursor/commands/create-pr.md is a plain text file containing
a path instead of being a symlink to the canonical command in
.agents/commands/create-pr.md; remove the plain file and replace it with a
symbolic link pointing to ../../.agents/commands/create-pr.md so that
.cursor/commands/create-pr.md is a symlink to .agents/commands/create-pr.md
(verify via ls -l to confirm the -> arrow), matching the DRY convention
described in .agents/commands/add-new-rule.md.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b9eb5383-d8cf-427d-8871-85149202e0d2

📥 Commits

Reviewing files that changed from the base of the PR and between ecd75e2 and 1e554fe.

📒 Files selected for processing (5)

• .agents/commands/add-new-rule.md
• .agents/commands/create-pr.md
• .agents/rules/000-global-standards.md
• .claude/skills/create-pr/SKILL.md
• .cursor/commands/create-pr.md

✅ Files skipped from review due to trivial changes (1)

• .claude/skills/create-pr/SKILL.md