Skip to content

fix(app): return 404 for unknown top-level routes - #1130

Closed
jeevanpillay wants to merge 1 commit into
mainfrom
fix/lightfast-unknown-route-status
Closed

fix(app): return 404 for unknown top-level routes#1130
jeevanpillay wants to merge 1 commit into
mainfrom
fix/lightfast-unknown-route-status

Conversation

@jeevanpillay

Copy link
Copy Markdown
Member

Summary

  • validate top-level organization routes against the active namespace registry before rendering the authenticated app shell
  • return TanStack not-found for absent or non-organization slugs
  • mark the existing app not-found HTML noindex
  • preserve valid organization slugs and the approved Lightfast public identity

Scope

Exactly five files: the organization TanStack adapter, its focused test, the app slug route, the app not-found component, and its focused route test. No app retirement, editorial copy, layout, canonical identity, Vercel dashboard, or unrelated cleanup is included.

Validation

  • app routing regression: 2/2 passed
  • organization adapter regression: 1/1 passed
  • founder identity regression: 4/4 passed
  • full API suite: 141 files, 975 tests passed
  • app and API typechecks passed
  • pinned repository checker: 1,763 files, no fixes
  • production compile build and broader implementation gates passed
  • independent review: no Critical or Important findings

The full app suite retains its documented unrelated baseline diagnostics: eight localStorage harness failures and one OAuth source-expectation failure. No changed-scope diagnostic was introduced.

Production gate

After protected merge, match the merge commit to READY production and verify arbitrary top-level unknown lightfast.ai paths return HTTP 404 with robots noindex, valid organization slugs remain valid, blog 404 behavior remains unchanged, and homepage identity/canonical/OG/discovery/assets remain healthy. Send supported Google and Bing indexing notifications only after those checks pass.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lightfast-app Error Error Aug 20, 2026 10:03am
lightfast-mcp Ready Ready Preview Aug 20, 2026 10:03am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
lightfast-www Skipped Skipped Aug 20, 2026 10:03am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 20a3d044-e07b-45cd-9a0d-12b3e1e25216

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeevanpillay

Copy link
Copy Markdown
Member Author

Closing as obsolete: this PR changes the deleted apps/app surface and its TanStack/API adapter contract. The hosted app has been retired. Preserving this branch and its history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant