Remove pitch deck route - #812
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d08970a574
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "paths": [ | ||
| "/opengraph-image-:hash", | ||
| "/pitch-deck", | ||
| "/integrations", |
There was a problem hiding this comment.
Keep retired deck path on public routing
Because lightfast-app is the default microfrontend, removing /pitch-deck from the marketing routing makes that public URL fall through to the authenticated app; apps/app/src/proxy.ts then redirects unauthenticated non-public paths to /sign-in. If the intent is to retire the deck, the path should still be claimed by a public marketing app so the deleted page can produce a public 404/410/redirect instead of sending old external links into the app sign-in flow.
Useful? React with 👍 / 👎.
d08970a
into
feat/www-start-core-infra
|
Folded this cleanup into #811 so the migration lands as one PR. |
Summary
apps/www/pitch-deckroute tree, slide/export helpers, pitch deck data, and pitch deck image assets./pitch-deckfrom MFE route ownership and stale nav/robots references.Stack
Test Plan
pnpm --filter @lightfast/app exec vitest run src/__tests__/microfrontends-config.test.tspnpm --filter @lightfast/www-start exec vitest run src/lib/seo-discovery.test.tspnpm --filter @lightfast/www-start typecheckpnpm --filter @lightfast/www-start buildcd apps/www && pnpm with-env next typegenpnpm --filter @lightfast/www typecheckpnpm --filter @lightfast/www build