Move some TestImageDatasetExport to TestDatasetExport - #1633
Merged
Conversation
Move the format-contract tests (COCO/YOLO/Pascal/captions output correctness, category sorting, mask handling, path defaults) from TestImageDatasetExport into a new TestDatasetExport, driving DatasetExport directly with the image mapping as substrate. These assert behavior shared by every sample type, so they belong to the base. Slim test_image_dataset_export.py to the image-specific delta: unit tests for the image_sample_to_image mapping (absolute path for COCO, relative name for YOLO/Pascal) plus one smoke that ImageDataset.export() binds it. No behavior change; coverage preserved. An upcoming VideoFrameDatasetExport only needs its own small mapping tests, not a copy of the format suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe PR reorganizes image dataset export tests and adds dedicated coverage for COCO captions, COCO detections and segmentation masks, YOLO detections, and Pascal VOC masks. Image-specific tests now focus on query forwarding and absolute or relative filename mapping. ChangesDataset export test coverage
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e04f038de8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MalteEbner
changed the title
Split the DatasetExport format tests into per-format files (test_dataset_export__coco_object_detections.py, __yolo_object_detections.py, __coco_captions.py, __coco_segmentation_masks.py, __pascal_voc.py), matching the test_<subject>__<topic>.py convention used in tests/core/image. The shared DatasetExport factory moves to tests/export/helpers.py. Restore query-forwarding coverage in the ImageDataset.export() smoke test, and drop the "bind"/"substrate" wording from docstrings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
build_dataset_export only re-did what ImageDatasetExport already does (bind the image sample-to-image mapping), so instantiate ImageDatasetExport directly in the format tests and remove tests/export/helpers.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MalteEbner
commented
Jul 14, 2026
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why
Move tests from TestImageDatasetExport to the new class TestDatasetExport. Split the latter across different files to keep the files small.
TestImageDatasetExport now only tests sample_to_image and that it is used correctly.
Review by Codex 5.5 extra high