feat: adding stochastic positional embeddings#1963
Open
kir-7 wants to merge 2 commits into
Open
Conversation
Contributor
|
/review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 86.36% 86.33% -0.04%
==========================================
Files 172 172
Lines 7358 7371 +13
==========================================
+ Hits 6355 6364 +9
- Misses 1003 1007 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@gabrielfruet The failing check seems to be regarding test coverage for ijepa.py for from_vit_encoder, should I add tests for this? And is there anything else I need to modify? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1900
Summary
add_stochastic_positional_noiseas utility function tolightly/models/utils.py.*
lightly/models/modules/ijepa.pyand*
ightly/models/modules/ijepa_timm.pytests/utils/test_stochastic_positional_embedding.pyto test the behaviour of StoP function while disabled and enabled.Additional details:
lightly/models/modulesdoes not provide functionality to modify the masks directly, these are modified while creating the MAE class (examples/pytorch/mae.py). These examples can be modified to evaluate StoP.