LDK Node Integration CI: Also patch LDK dependencies if git
#4283
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By now, we switched our LDK Node `main` to a specific commit on LDK's `main`. Since we don't have the `crates.io` dependencies in the `Cargo.toml`, the patch command won't actually do anything but silently fail, i.e., *not* check the PR changes against the LDK Node main branch. Here we fix this by also patching the git repository path.
|
I've assigned @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4283 +/- ##
========================================
Coverage 89.37% 89.38%
========================================
Files 180 180
Lines 139395 139847 +452
Branches 139395 139847 +452
========================================
+ Hits 124591 124996 +405
- Misses 12216 12258 +42
- Partials 2588 2593 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
approved these changes
Dec 12, 2025
| lightning-liquidity = { path = "../rust-lightning/lightning-liquidity" } | ||
| lightning-macros = { path = "../rust-lightning/lightning-macros" } | ||
| [patch."https://github.com/lightningdevkit/rust-lightning"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By now, we switched our LDK Node
mainto a specific commit on LDK'smain. Since we don't have thecrates.iodependencies in theCargo.toml, the patch command won't actually do anything but silently fail, i.e., not check the PR changes against the LDK Node main branch.Here we fix this by also patching the git repository path.