Skip to content

Implemented CORS mechanism#2423

Open
maifeeulasad wants to merge 21 commits into
lightpanda-io:mainfrom
maifeeulasad:feat-cors-maifee
Open

Implemented CORS mechanism#2423
maifeeulasad wants to merge 21 commits into
lightpanda-io:mainfrom
maifeeulasad:feat-cors-maifee

Conversation

@maifeeulasad

Copy link
Copy Markdown

closes #2015

@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@maifeeulasad

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@maifeeulasad
maifeeulasad marked this pull request as draft May 11, 2026 17:12
Co-authored-by: Copilot <copilot@github.com>
@maifeeulasad
maifeeulasad marked this pull request as ready for review May 11, 2026 20:44
@maifeeulasad

Copy link
Copy Markdown
Author

When I ran the v8 in debug mode locally I had no issues. It passed. Here is the exact command.

ZIG_V8_VERSION=v0.4.4                                                            
V8_VERSION=14.0.365.4
OS=linux
ARCH=x86_64
CACHE_DIR=~/.cache

mkdir -p "$CACHE_DIR/v8" v8
wget -O "$CACHE_DIR/v8/libc_v8.a" \
  "https://github.com/lightpanda-io/zig-v8-fork/releases/download/${ZIG_V8_VERSION}/libc_v8_${V8_VERSION}_${OS}_${ARCH}_debug.a"
ln -sf "$CACHE_DIR/v8/libc_v8.a" v8/libc_v8_debug.a

zig build -Dprebuilt_v8_path=~/.cache/v8/libc_v8.a -Dtsan=true test

And regarding demo runner I am bit confused now! Care to guide me please? So that we can get this done!

cc: @krichprollsch

@krichprollsch

Copy link
Copy Markdown
Member

@maifeeulasad no worries, we have flaky tests. I will re-start them, not a blocker for review.

@maifeeulasad

Copy link
Copy Markdown
Author

@krichprollsch eagerly waiting for reviews and open for change requests.

Comment thread src/network/Cors.zig
@maifeeulasad
maifeeulasad marked this pull request as draft May 17, 2026 12:50
@maifeeulasad
maifeeulasad marked this pull request as ready for review June 10, 2026 17:22
@maifeeulasad

Copy link
Copy Markdown
Author

@krichprollsch done! cors is now part of init, so both server side and client side cors is implemented

care to take another look please?

@thfrod

thfrod commented Jul 16, 2026

Copy link
Copy Markdown

@krichprollsch any updates on the review of this PR?

@krichprollsch

Copy link
Copy Markdown
Member

We merged an important refacto in the HTTP stack recently. We removed the layer model. I'm afraid this PR was heavily impacted. But we are working on CORS implementation internally. So I hope the feature lands in a couple of weeks.

@maifeeulasad

Copy link
Copy Markdown
Author

@krichprollsch I am open to rebase my changes and also open for upcoming reviews, if there are any.

But if the internal team decides to discard other works, that works for me as well.

Just let us know, if we are going to work on it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement CORS mechanism

3 participants