Implemented CORS mechanism#2423
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: Copilot <copilot@github.com>
|
When I ran the v8 in debug mode locally I had no issues. It passed. Here is the exact command. And regarding demo runner I am bit confused now! Care to guide me please? So that we can get this done! cc: @krichprollsch |
|
@maifeeulasad no worries, we have flaky tests. I will re-start them, not a blocker for review. |
|
@krichprollsch eagerly waiting for reviews and open for change requests. |
…owser into feat-cors-maifee
|
@krichprollsch done! cors is now part of init, so both server side and client side cors is implemented care to take another look please? |
|
@krichprollsch any updates on the review of this PR? |
|
We merged an important refacto in the HTTP stack recently. We removed the layer model. I'm afraid this PR was heavily impacted. But we are working on CORS implementation internally. So I hope the feature lands in a couple of weeks. |
|
@krichprollsch I am open to rebase my changes and also open for upcoming reviews, if there are any. But if the internal team decides to discard other works, that works for me as well. Just let us know, if we are going to work on it or not. |
closes #2015