Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/grid-visualizer/src/data/currencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const currencies: FiatCurrency[] = [
accountType: 'UPI',
accountLabel: 'UPI',
instantRails: ['UPI'],
allRails: ['UPI', 'IMPS'],
allRails: ['UPI'],
examplePerson: { fullName: 'Priya Sharma', nationality: 'IN' },
},
{
Expand Down
1 change: 0 additions & 1 deletion mintlify/openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mintlify/snippets/country-support.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇭🇰 Hong Kong | HK | `Bank Transfer` |
| 🇭🇺 Hungary | HU | `SEPA` `SEPA Instant` |
| 🇮🇸 Iceland | IS | `SEPA` `SEPA Instant` |
| 🇮🇳 India | IN | `UPI` `IMPS` |
| 🇮🇳 India | IN | `UPI` |
| 🇮🇩 Indonesia | ID | `Bank Transfer` |
| 🇮🇪 Ireland | IE | `SEPA` `SEPA Instant` |
| 🇮🇹 Italy | IT | `SEPA` `SEPA Instant` |
Expand Down
1 change: 0 additions & 1 deletion openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion openapi/components/schemas/common/InrAccountInfo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ properties:
type: string
enum:
- UPI
Comment on lines 14 to 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking API change — no deprecation period

Removing IMPS from the paymentRails enum is a non-backwards-compatible change. InrAccountInfo is composed into both PaymentInrAccountInfo (response) and InrExternalAccountInfo (used in external-account creation request bodies at the /external-accounts endpoint). Any existing API clients that currently supply "IMPS" in the paymentRails array when creating or reading an INR external account will:

  1. Fail schema validation on requests that include IMPS.
  2. Receive unexpected responses if the backend still returns IMPS (which isn't changed by this PR).

Before hard-removing the value, the standard approach would be to:

  1. Deprecate IMPS in the schema (add a description/deprecated: true annotation) and give integrators a migration window.
  2. Only remove the value once all in-flight usage is confirmed to be zero.

If IMPS has already been sunset at the backend level and zero customers are using it, that context would be helpful to document here (e.g., a comment or PR note).

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/InrAccountInfo.yaml
Line: 14-16

Comment:
**Breaking API change — no deprecation period**

Removing `IMPS` from the `paymentRails` enum is a non-backwards-compatible change. `InrAccountInfo` is composed into both `PaymentInrAccountInfo` (response) **and** `InrExternalAccountInfo` (used in external-account creation request bodies at the `/external-accounts` endpoint). Any existing API clients that currently supply `"IMPS"` in the `paymentRails` array when creating or reading an INR external account will:

1. Fail schema validation on requests that include `IMPS`.
2. Receive unexpected responses if the backend still returns `IMPS` (which isn't changed by this PR).

Before hard-removing the value, the standard approach would be to:
1. Deprecate `IMPS` in the schema (add a description/`deprecated: true` annotation) and give integrators a migration window.
2. Only remove the value once all in-flight usage is confirmed to be zero.

If IMPS has already been sunset at the backend level and zero customers are using it, that context would be helpful to document here (e.g., a comment or PR note).

How can I resolve this? If you propose a fix, please make it concise.

- IMPS
vpa:
type: string
description: The VPA of the bank