Add documentation for MWK, UGX, and XOF mobile money accounts#245
Open
claude[bot] wants to merge 2 commits intomainfrom
Open
Add documentation for MWK, UGX, and XOF mobile money accounts#245claude[bot] wants to merge 2 commits intomainfrom
claude[bot] wants to merge 2 commits intomainfrom
Conversation
Add external account examples and validation code for three new African mobile money currencies introduced in recent OpenAPI changes: - MWK (Malawi) mobile money - UGX (Uganda) mobile money - XOF (West Africa - Senegal, Benin, Ivory Coast) mobile money Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR adds documentation for three new African mobile money account types (MWK, UGX, XOF) to What's included:
Assessment:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| mintlify/snippets/external-accounts.mdx | Adds three new mobile money account tabs (MWK, UGX, XOF) with curl examples and validation patterns. MWK and UGX documentation is consistent with existing tabs and includes both phone format details and accepted provider lists. The XOF tab's note is less descriptive: it omits per-country digit format specifications (Senegal: 9, Ivory Coast: 10, Benin: 8–9 digits) that are embedded in the validation regex and explicitly documented in other tabs. This creates an inconsistency that could leave developers guessing about expected phone formats for Ivory Coast or Benin. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[POST /customers/external-accounts] --> B{currency}
B -->|MWK| C["accountType: MWK_ACCOUNT<br/>phone: +265 + 9 digits<br/>providers: AIRTEL, TNM<br/>✓ Documented"]
B -->|UGX| D["accountType: UGX_ACCOUNT<br/>phone: +256 + 9 digits<br/>providers: MTN, AIRTEL<br/>✓ Documented"]
B -->|XOF| E["accountType: XOF_ACCOUNT<br/>Senegal +221: 9 digits<br/>Ivory Coast +225: 10 digits<br/>Benin +229: 8–9 digits<br/>⚠️ Note lacks format details"]
C --> F["beneficiary: INDIVIDUAL<br/>nationality, address"]
D --> F
E --> F
Last reviewed commit: ec70aa2
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment on lines
+498
to
+500
| <Note> | ||
| Supported countries: Senegal (+221), Benin (+229), and Ivory Coast (+225). Phone formats vary by country. | ||
| </Note> |
Contributor
There was a problem hiding this comment.
The XOF note states "Phone formats vary by country" but doesn't specify the per-country digit requirements. However, the validation regex (line 720) and other mobile money tabs show this information is important for developers:
- Senegal (+221): exactly 9 digits
- Ivory Coast (+225): exactly 10 digits
- Benin (+229): 8–9 digits
For consistency with the Malawi, Uganda, and Rwanda tabs, the note should explicitly document the per-country digit formats:
Suggested change
| <Note> | |
| Supported countries: Senegal (+221), Benin (+229), and Ivory Coast (+225). Phone formats vary by country. | |
| </Note> | |
| <Note> | |
| Supported countries and phone formats: | |
| - Senegal (+221): `+221XXXXXXXXX` (9 digits after country code) | |
| - Ivory Coast (+225): `+225XXXXXXXXXX` (10 digits after country code) | |
| - Benin (+229): `+229XXXXXXXX` or `+229XXXXXXXXX` (8–9 digits after country code) | |
| </Note> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/external-accounts.mdx
Line: 498-500
Comment:
The XOF note states "Phone formats vary by country" but doesn't specify the per-country digit requirements. However, the validation regex (line 720) and other mobile money tabs show this information is important for developers:
- Senegal (+221): exactly 9 digits
- Ivory Coast (+225): exactly 10 digits
- Benin (+229): 8–9 digits
For consistency with the Malawi, Uganda, and Rwanda tabs, the note should explicitly document the per-country digit formats:
```suggestion
<Note>
Supported countries and phone formats:
- Senegal (+221): `+221XXXXXXXXX` (9 digits after country code)
- Ivory Coast (+225): `+225XXXXXXXXXX` (10 digits after country code)
- Benin (+229): `+229XXXXXXXX` or `+229XXXXXXXXX` (8–9 digits after country code)
</Note>
```
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Recent OpenAPI schema changes added support for three new African mobile money currencies:
The
mintlify/snippets/external-accounts.mdxdocumentation was missing examples for these account types.Test plan
🤖 Generated with Claude Code