Skip to content

LCORE-1800: Add OpenTelemetry dependencies for instrumentation#2186

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
anik120:otel-dep
Jul 21, 2026
Merged

LCORE-1800: Add OpenTelemetry dependencies for instrumentation#2186
tisnik merged 1 commit into
lightspeed-core:mainfrom
anik120:otel-dep

Conversation

@anik120

@anik120 anik120 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Add minimal required OpenTelemetry dependencies to enable instrumentation of the FastAPI application.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • New Features
    • Added support for OpenTelemetry-based observability and telemetry export.
    • Enabled instrumentation for FastAPI applications.

Add minimal required OpenTelemetry dependencies to enable instrumentation
of the FastAPI application.
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: be7690d7-1889-4474-8e6f-b7d98190484c

📥 Commits

Reviewing files that changed from the base of the PR and between b35bce4 and 1ef510c.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-7-e2e-tests / lightspeed-stack-0-7
🧰 Additional context used
📓 Path-based instructions (2)
**/*

📄 CodeRabbit inference engine (Custom checks)

**/*: Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.
Flag N+1 patterns that list items and then query once per item, including Kubernetes API and database access.
Flag expensive work inside loops, including API calls, JSON parsing, and regex compilation.
Flag unbounded growth in caches, watchers, or buffers when eviction or limits are missing.
Flag missing pagination or limits on list operations and API endpoints.
Flag secrets or tokens logged in plaintext or hardcoded in source.
Flag API endpoints missing authentication or authorization.
Flag injection vulnerabilities, including SQL injection, command injection, and path traversal.
Flag sensitive data leaked in API responses, WebSocket messages, or logs.
Flag Kubernetes Secrets and Red Hat secrets missing OwnerReferences.

Never commit secrets or keys; use environment variables for sensitive data.

Files:

  • pyproject.toml
pyproject.toml

📄 CodeRabbit inference engine (AGENTS.md)

Check existing dependencies and their current versions in pyproject.toml before adding dependencies or assuming library versions.

Files:

  • pyproject.toml
🔇 Additional comments (1)
pyproject.toml (1)

85-88: 📐 Maintainability & Code Quality

Keep the pyproject bounds as-is. uv.lock already pins these OpenTelemetry packages (opentelemetry-distro 0.63b1, opentelemetry-exporter-otlp 1.42.1, opentelemetry-instrumentation-fastapi 0.63b1), and the repo’s Konflux flow requires locked dependencies.

			> Likely an incorrect or invalid review comment.

Walkthrough

The project’s runtime dependencies now include OpenTelemetry distribution, OTLP exporter, and FastAPI instrumentation packages.

Changes

OpenTelemetry Dependencies

Layer / File(s) Summary
Runtime dependency update
pyproject.toml
Adds opentelemetry-distro, opentelemetry-exporter-otlp, and opentelemetry-instrumentation-fastapi to the project dependencies.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tisnik, asimurka

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: adding OpenTelemetry dependencies to enable instrumentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed Only dependency metadata/lockfile changed; no loops, queries, pagination, caches, or other algorithmic code was added.
Security And Secret Handling ✅ Passed Only dependency metadata/lockfile changed; no secrets, auth endpoints, injections, leaks, or K8s secret refs were touched.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik

tisnik commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/retest

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik

tisnik commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tisnik

tisnik commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tisnik
tisnik merged commit 066c991 into lightspeed-core:main Jul 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants