Skip to content

LCORE-2882: make e2e fail on error or test failure in konflux#2190

Open
radofuchs wants to merge 2 commits into
lightspeed-core:mainfrom
radofuchs:LCORE_2882_e2e_fail_onError
Open

LCORE-2882: make e2e fail on error or test failure in konflux#2190
radofuchs wants to merge 2 commits into
lightspeed-core:mainfrom
radofuchs:LCORE_2882_e2e_fail_onError

Conversation

@radofuchs

@radofuchs radofuchs commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

Make integration test fail on konflux if error or test failure happen

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Bug Fixes
    • End-to-end integration test pipeline failures are now reported correctly instead of being ignored.
    • Pipeline runs now accurately reflect non-zero test exits.
  • Tests
    • Reduced the set of feature tests included in the e2e test list.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 84fe1e2a-c83a-4a5b-b280-c9a4d8e58bb2

📥 Commits

Reviewing files that changed from the base of the PR and between 330b66e and 1ac8916.

📒 Files selected for processing (1)
  • tests/e2e/test_list.txt
💤 Files with no reviewable changes (1)
  • tests/e2e/test_list.txt
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: E2E: library mode / ci / group 3
  • GitHub Check: E2E: server mode / ci / group 2
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-7-on-pull-request

Walkthrough

The integration test pipeline now propagates run-e2e-tests failures to the PipelineRun. The E2E test list was reduced to four feature tests.

Changes

Integration test pipeline and E2E test selection

Layer / File(s) Summary
Propagate integration test failures
.tekton/integration-tests/pipeline/lightspeed-stack-integration-test.yaml
Removes onError: continue from run-e2e-tests and documents the failure-enforcement requirement.
Reduce E2E test list
tests/e2e/test_list.txt
Retains only the authorized no-op, health, info, and models feature tests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tisnik

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main CI change: Konflux e2e tests now fail on errors or test failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed No meaningful perf regressions found; the YAML change is failure-handling/commentary only, and test_list.txt just removes entries, reducing test work.
Security And Secret Handling ✅ Passed Changed files only adjust Tekton failure handling and reduce e2e test selection; no secrets, auth, injection, or secret-ownerRef changes found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant