Repository navigation
Automate releases - #101
Merged
eliias merged 1 commit intoAug 18, 2026
Merged
Conversation
eliias
force-pushed
the
hannesmoser/inf-3414-automate-linear-zapier-releases
branch
10 times, most recently
from
August 17, 2026 09:35
b70e820 to
b9a7e83
Compare
eliias
marked this pull request as ready for review
August 17, 2026 10:26
Contributor
Author
|
@codex review |
delicb
approved these changes
Aug 17, 2026
delicb
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, left some inline comments.
Publishing this app is manual today, and the repo drifted from what Zapier runs: #99 had to reconstruct 4.10.0 through 4.14.0 out of the published app and back into git. Bump the minor version and write the changelog entry in the same PR as the code. CI fails the PR when code that reaches Zapier changes without that. Merging uploads that version to Zapier and promotes it, so new Zaps get it. Existing Zaps keep the version they were built on, because nothing migrates them. The release workflow asks Zapier which versions it holds rather than inferring from the push, so a release that never arrived is retried on the next push to master, or from the Actions tab. That is also why there is one workflow here and not three. Check the promote step. It passes --yes, without which the CLI waits on a prompt nobody can answer on a runner, and that flag also accepts Zapier's non-blocking pre-check warnings. The repo moves to Node 22, because the Zapier CLI that CI installs pulls dependencies that refuse to install below Node 20. Zapier still runs this app on Node 18, and will until we move to core 17. Towards INF-3414
eliias
force-pushed
the
hannesmoser/inf-3414-automate-linear-zapier-releases
branch
from
August 17, 2026 12:15
b9a7e83 to
5601e6f
Compare
Contributor
Author
|
@delicb I'd like to do a test run this week, do you mind babysitting this with me? |
Contributor
|
Sorry, I missed this comment. Yes, of course, count on me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing this app is manual today, and the repo drifted from what Zapier runs: #99 had to reconstruct 4.10.0 through 4.14.0 out of the published app and back into git.
Bump the minor version and write the changelog entry in the same PR as the code. CI fails the PR when code that reaches Zapier changes without that. Merging uploads that version to Zapier and promotes it, so new Zaps get it. Existing Zaps keep the version they were built on, because nothing migrates them.
flowchart TD pr([Pull request]) --> ci merge{{Merge to master}} --> ci subgraph nodejs[nodejs.yml] ci[Test, validate the schema, require a version bump] end ci -->|on a branch| ready([Ready to merge]) ready --> merge ci -->|on master| ask subgraph release[release.yml] ask{Is this version at Zapier?} stop([Stop]) upload[Upload] promote[Promote and poll] end ask -->|yes| stop ask -->|no| upload upload --> promote promote --> live([New Zaps get it, existing Zaps keep their version])The release workflow asks Zapier which versions it holds rather than inferring from the push, so a release that never arrived is retried on the next push to master, or from the Actions tab. That is also why there is one workflow here and not three.
Check the promote step. It passes
--yes, without which the CLI waits on a prompt nobody can answer on a runner, and that flag also accepts Zapier's non-blocking pre-check warnings.The repo moves to Node 22, because the Zapier CLI that CI installs pulls dependencies that refuse to install below Node 20. Zapier still runs this app on Node 18, and will until we move to core 17.
ZAPIER_DEPLOY_KEYsecret, taken from the shared Zapier account in 1Password, before merging. The release workflow fails on its first run without it.Towards INF-3414