Track sizing support in Grid widget and view#1794
Conversation
7fd925e to
62cc580
Compare
f42ed69 to
3bc58b7
Compare
|
Thanks for the work! Not sure I'll have time to review it in the coming weeks, but I definitely appreciate changes that get us closer to CSS Grid behavior. At first glance, my impression is that this PR makes a lot of drive-by changes to the API, some of which I don't agree with. For instance, I don't see a reason to remove Anyway, I'll do a more in-depth review soon. This is work we really want to get merged! |
I removed that and unified its functionality into
I would replace the tuples with |
1e27c91 to
f672300
Compare
|
(I'm back from RustWeek, will probably review this tomorrow!) |
... and additional fallout [skip actions]
This completely reworks how the Grid widget lays its children out.
The new implementation closely follows CSS grid specification with one intentional deviation, it does not support minmax track size. It has been omitted from track sizing MVP and because I don't find it very useful.