Skip to content

feat: tekton optional ui #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElderMatt merged 6 commits into from
Mar 31, 2026
Merged

feat: tekton optional ui #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ccd6ea
feat: tekton optional ui
dennisvankekem Mar 27, 2026
1832a17
fix: toggle view for banner link
dennisvankekem Mar 27, 2026
951844a
Update src/pages/builds/create-edit/BuildsCreateEditPage.tsx
dennisvankekem Mar 31, 2026
428c437
Update src/pages/builds/create-edit/BuildsCreateEditPage.tsx
dennisvankekem Mar 31, 2026
c35eec1
Update src/pages/builds/overview/BuildsOverviewPage.tsx
dennisvankekem Mar 31, 2026
e67542a
fix: add useHistory
ferruhcihan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/ListTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ interface ListTableProps extends EnhancedTableProps {
to?: string
customButton?: React.ReactElement
customButtonText?: React.ReactElement
createButtonDisabled?: boolean

hasDropdownFilter?: boolean
dropdownFilterLabel?: string
Expand All @@ -39,6 +40,7 @@ export default function ({
to,
customButton = null,
customButtonText = null,
createButtonDisabled = false,

hasDropdownFilter = false,
dropdownFilterLabel = 'Filter',
Expand Down Expand Up @@ -66,7 +68,6 @@ export default function ({
const [internalSelected, setInternalSelected] = useState<string>('')
const selectedFilter = dropdownFilterValue ?? internalSelected

// When items load/change, select first item if nothing selected
useEffect(() => {
if (!hasDropdownFilter) return
if (selectedFilter) return
Expand Down Expand Up @@ -100,7 +101,13 @@ export default function ({

{(isPlatformAdmin || oboTeamId) && !noCrud && (
<Box mb={1}>
<Button variant='contained' component={Link} to={redirect} data-cy={`button-create-${resourceType}`}>
<Button
variant='contained'
component={Link}
to={redirect}
disabled={createButtonDisabled}
data-cy={`button-create-${resourceType}`}
>
{customButtonText || t('BUTTON_NEW_RESOURCE', { model: resourceType })}
</Button>
</Box>
Expand Down
Loading
Loading