Conversation
Contributor
|
Comparison of Helm chart templating output: @@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/valkey-data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage
@@ spec.volumeClaimTemplates.v1/PersistentVolumeClaim/data.spec @@
! + one map entry added:
+ storageClassName: linode-block-storage
|
merll
reviewed
Mar 19, 2026
merll
reviewed
Mar 19, 2026
merll
reviewed
Mar 19, 2026
Contributor
|
I am fine with the main functionality of this branch, but it contains lots of unrelated changes which make it harder to read and later follow up in case someone is looking into old code. I also doubt such changes can be properly QA'ed when they are not used in any recent environment. I would suggest either
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the storage class being used for gitea-valkey and oauth2-proxy, it is now set to linode-block-storage instead of linode-block-storage-retain. Migration has also been added to delete and recreate the pvcs.