Add support for resource locks #852
Open
+1,148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual fix from the API side is expected in the next few weeks
zliang-akamai
requested review from
ezilber-akamai and
vshanthe
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for resource locks API, enabling users to create, retrieve, list, and delete locks on Linode resources to prevent accidental deletion.
Key changes:
- New locks API client methods (Create, Get, List, Delete)
- Integration tests validating lock functionality
- Instance model extended to expose applied locks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| locks.go | Implements Lock types and API client methods for lock operations |
| instances.go | Adds Locks field to Instance struct to expose lock states |
| test/integration/locks_test.go | Integration tests covering lock CRUD operations and instance lock field |
| test/integration/fixtures/TestLocks.yaml | HTTP fixtures for lock integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for resource locks related API changes.
✔️ How to Test
make TEST_ARGS="-run TestLocks" fixturesThis is a known issue in the API and is expected to be fixed soon:
I manually patched the fixtures to avoid the CI failure. We will be able to verify the API fix and regenerate the fixtures weeks later.