Skip to content

fix: prevent runtime events from updating multiple Combo UI components #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linw1995 merged 1 commit into from
Jan 22, 2026
Merged

fix: prevent runtime events from updating multiple Combo UI components #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/coco-tui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ bon.workspace = true
ctor.workspace = true
lazy_static.workspace = true
bitflags = "2.10.0"
uuid = { version = "1.11.0", features = ["v4"] }
indoc.workspace = true
time = { workspace = true, features = [
"macros",
Expand Down
45 changes: 27 additions & 18 deletions crates/coco-tui/src/components/chat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ use time::OffsetDateTime;
use tokio::time::Instant;
use tokio_util::sync::CancellationToken;
use tracing::{debug, warn};
use uuid::Uuid;

use super::{
Action, AnswerEvent, AskEvent, BotMessage, BotStreamKind, CacheInvalidation, Combo,
Expand Down Expand Up @@ -488,17 +489,7 @@ impl Chat<'static> {
tokio::task::spawn(task_combo_discover(cancel_token));
}

fn spawn_combo_execute(&mut self, name: String, args: Vec<String>) {
// Generate a unique tool use id
let id = format!(
"toolu_{:016x}",
std::time::SystemTime::now()
.duration_since(std::time::UNIX_EPOCH)
.unwrap()
.as_nanos()
% (1u128 << 64)
);

fn spawn_combo_execute(&mut self, id: String, name: String, args: Vec<String>) {
// Create tool use for run_combo
let tool_use = ToolUse {
id,
Expand Down Expand Up @@ -547,18 +538,24 @@ impl Chat<'static> {
}
}

fn combo_tool_event_to_combo_event(&self, event: &ComboToolEvent) -> ComboEvent {
fn combo_tool_event_to_combo_event(&self, id: &str, event: &ComboToolEvent) -> ComboEvent {
match event {
ComboToolEvent::NotFound { name } => ComboEvent::NotFound { name: name.clone() },
ComboToolEvent::NotFound { name } => ComboEvent::NotFound {
id: id.to_string(),
name: name.clone(),
},
ComboToolEvent::Executing { name, command_line } => ComboEvent::Executing {
id: id.to_string(),
name: name.clone(),
command_line: command_line.clone(),
},
ComboToolEvent::Output { name, chunk } => ComboEvent::Output {
id: id.to_string(),
name: name.clone(),
chunk: chunk.clone(),
},
ComboToolEvent::RecordStart { name, tool_use } => ComboEvent::RecordStart {
id: id.to_string(),
name: name.clone(),
tool_use: tool_use.clone(),
},
Expand All @@ -567,6 +564,7 @@ impl Chat<'static> {
tool_use_id,
chunk,
} => ComboEvent::RecordOutput {
id: id.to_string(),
name: name.clone(),
tool_use_id: tool_use_id.clone(),
chunk: chunk.clone(),
Expand All @@ -577,6 +575,7 @@ impl Chat<'static> {
is_error,
output,
} => ComboEvent::RecordEnd {
id: id.to_string(),
name: name.clone(),
tool_use_id: tool_use_id.clone(),
is_error: *is_error,
Expand All @@ -587,6 +586,7 @@ impl Chat<'static> {
prompt,
thinking,
} => ComboEvent::Prompt {
id: id.to_string(),
name: name.clone(),
prompt: prompt.clone(),
thinking: thinking.clone(),
Expand All @@ -597,6 +597,7 @@ impl Chat<'static> {
kind,
text,
} => ComboEvent::PromptStream {
id: id.to_string(),
name: name.clone(),
index: *index,
kind: match kind {
Expand All @@ -611,6 +612,7 @@ impl Chat<'static> {
thinking,
offload,
} => ComboEvent::ReplyToolUse {
id: id.to_string(),
name: name.clone(),
tool_use: tool_use.clone(),
thinking: thinking.clone(),
Expand All @@ -622,6 +624,7 @@ impl Chat<'static> {
is_error,
output,
} => ComboEvent::ReplyToolResult {
id: id.to_string(),
name: name.clone(),
tool_use_id: tool_use_id.clone(),
is_error: *is_error,
Expand All @@ -635,11 +638,15 @@ impl Chat<'static> {
starter,
exit_code,
} => ComboEvent::Executed {
id: id.to_string(),
name: name.clone(),
starter: starter.clone(),
exit_code: *exit_code,
},
ComboToolEvent::Cancelled { name } => ComboEvent::Cancelled { name: name.clone() },
ComboToolEvent::Cancelled { name } => ComboEvent::Cancelled {
id: Some(id.to_string()),
name: name.clone(),
},
}
}

Expand Down Expand Up @@ -1215,7 +1222,7 @@ impl Component for Chat<'static> {
serde_json::from_value::<RunComboInput>(tool_use.input.clone())
{
combo_tool_ids.push(tool_use.id.clone());
Message::bot(Combo::new(&input.combo_name).into())
Message::bot(Combo::new(&tool_use.id, &input.combo_name).into())
} else {
Message::bot(Tool::new(tool_use.to_owned()).into())
}
Expand Down Expand Up @@ -1308,7 +1315,7 @@ impl Component for Chat<'static> {
global::trigger_schedule_session_save();
}
Event::Answer(AnswerEvent::ComboToolEvent { id, event }) => {
let combo_event = self.combo_tool_event_to_combo_event(event);
let combo_event = self.combo_tool_event_to_combo_event(id, event);
if !self.combo_tool_messages.contains(id) {
self.pending_combo_tool_events
.entry(id.clone())
Expand Down Expand Up @@ -1490,9 +1497,10 @@ impl Component for Chat<'static> {
self.spawn_combo_discover();
}
ComboAction::Execute { name, args } => {
let combo = Combo::new(name);
let id = format!("toolu_{}", Uuid::new_v4().as_simple());
let combo = Combo::new(&id, name);
self.messages.push(Message::user(combo.into()));
self.spawn_combo_execute(name.clone(), args.clone());
self.spawn_combo_execute(id, name.clone(), args.clone());
debug!("Combo message pushed");
}
},
Expand Down Expand Up @@ -1709,6 +1717,7 @@ async fn discover_combo_starters(
if result.cancelled || cancel_token.is_cancelled() {
tx.send(
ComboEvent::Cancelled {
id: None,
name: name.map(str::to_string),
}
.into(),
Expand Down
Loading