Skip to content

ci: share IRSA to pr namespace ServiceAccount - #1028

Draft
paulfouquet wants to merge 3 commits into
masterfrom
ci/share-irsa-to-pr-namespace-serviceaccount
Draft

ci: share IRSA to pr namespace ServiceAccount#1028
paulfouquet wants to merge 3 commits into
masterfrom
ci/share-irsa-to-pr-namespace-serviceaccount

Conversation

@paulfouquet

@paulfouquet paulfouquet commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Motivation

The PR namespace Service Account needs a IRSA (IAM Role for ServiceAccount) to be able to do some operations on buckets and assume other shared roles.

ServiceAccount in the argo namespace:

Name:                workflow-runner-sa
Namespace:           argo
Labels:              app.kubernetes.io/name=workflow-runner-sa
                     aws.cdk.eks/prune-abc
Annotations:         eks.amazonaws.com/role-arn: arn:aws:iam::012345678910:role/Workflows-EksWorkflowsArgoRunnerServiceAccountRole-abc
Image pull secrets:  <none>
Mountable secrets:   <none>
Tokens:              <none>
Events:              <none>

ServiceAccount in the pr-* namespace:

Name:                workflow-runner-sa
Namespace:           pr-*
Labels:              <none>
Annotations:         <none>
Image pull secrets:  <none>
Mountable secrets:   <none>
Tokens:              <none>
Events:              <none>

Modifications

  • Create a IRSA for the pr-* ServiceAccounts
  • Modify the ServiceAccount creation template to allow passing this IRSA as a GH secret

TODO

Deploy:
image

Verification

TODO

@paulfouquet paulfouquet added the workflows Deploy workflows in temporary namespace label Jun 5, 2025
@paulfouquet paulfouquet added workflows Deploy workflows in temporary namespace and removed workflows Deploy workflows in temporary namespace labels Jun 5, 2025
@paulfouquet paulfouquet self-assigned this Jun 5, 2025
@paulfouquet
paulfouquet marked this pull request as ready for review June 5, 2025 22:51
@paulfouquet
paulfouquet requested review from a team as code owners June 5, 2025 22:51
@paulfouquet

Copy link
Copy Markdown
Contributor Author

Putting this PR on hold (Draft) as it is not complying with security requirements:

Any production secrets must be defined in an environment that is only accessible by the main/master branch.

@paulfouquet
paulfouquet marked this pull request as draft June 9, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants