fix: retry on pod termination failure TDE-2017 - #1252
Merged
Conversation
amfage
marked this pull request as draft
August 9, 2026 20:58
amfage
marked this pull request as ready for review
August 9, 2026 21:55
ctali
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A change of behaviour (cause unknown but probably Karpenter or EKS upgrade) means that when a Spot Instance is interrupted, i.e. reclaimed by AWS, the pods are now aware of the grace period. Previously a pod would retry on on Error (the phase message was "pod deleted"). The new behaviour is to fail with Failure and a phase message of "Pod was terminated in response to imminent node shutdown."
Modifications
Change the default
retryStrategyto handle the new behaviour by matching the failure message string. We cannot just useonFailureas that will also match intentional application failures.Verification
Applied to NonProd environment and tested using AWS Fault Injection Service to simulate a Spot Instance interruption.