Skip to content

test(herdr): fix Quick Start close test on Linux CI (util-linux script syntax) #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lis186 merged 1 commit into from
Aug 17, 2026
Merged

test(herdr): fix Quick Start close test on Linux CI (util-linux script syntax) #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/herdr-plugin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,10 +1016,17 @@ describe('Herdr Quick Start close', () => {
// stdin is held open far longer than the poll window on purpose: otherwise
// the process would exit on stdin EOF and the test would pass for the wrong
// reason. Seeing the marker inside the window means `q` itself ended it.
const command = `( printf 'q'; sleep 40 ) | script -q /dev/null `
+ `env CCXRAY_HOME=${JSON.stringify(home)} HERDR_CONFIG_PATH=${JSON.stringify(cfg)} `
// BSD script (macOS) takes the command as positional args after the file;
// util-linux script (Linux CI) rejects positional commands and needs -c.
const run = `env CCXRAY_HOME=${JSON.stringify(home)} HERDR_CONFIG_PATH=${JSON.stringify(cfg)} `
+ `CCXRAY_PRICING_CACHE=/nonexistent/p.json HERDR_PANE_ID= `
+ `/bin/sh -c ${JSON.stringify(inner)} >/dev/null 2>&1 &\n`
+ `/bin/sh -c ${JSON.stringify(inner)}`;
const pty = process.platform === 'linux'
? `script -qec ${JSON.stringify(run)} /dev/null`
: `script -q /dev/null ${run}`;
// The job-level redirect covers the feeder subshell too — its inherited
// stderr would otherwise hold spawnSync's pipe open until the sleep ends.
const command = `{ ( printf 'q'; sleep 12 ) | ${pty}; } >/dev/null 2>&1 &\n`
+ `for i in $(seq 1 40); do [ -f ${JSON.stringify(marker)} ] && break; sleep 0.2; done\n`
+ `[ -f ${JSON.stringify(marker)} ] && echo EXITED || echo LINGERED\n`
+ `pkill -f ${JSON.stringify(onboarding)} 2>/dev/null; true`;
Expand Down
Loading