fix: show OCSP stapling as informational, not pass/fail#307
Merged
lissy93 merged 1 commit intoMay 18, 2026
Conversation
The OCSP Stapling row in the TLS Connection card used the yesNo() helper, rendering '❌ No' when the server doesn't staple OCSP responses. Since OCSP stapling is a performance optimization rather than a security requirement, displaying it as a failure is misleading. Replaced with a neutral ocspStatus() that shows 'Yes' or 'Not enabled' without emoji icons. The analysis rule (tls-connection.ts) already uses severity 'info' for this check, so the Advisory panel was correct; only the card display was wrong. Closes lissy93#299
✅ Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lissy93
approved these changes
May 18, 2026
lissy93
reviewed
May 18, 2026
| <Row lbl="Forward Secrecy" val={yesNo(!!d.forwardSecrecy)} /> | ||
| <Row lbl="Session Resumption" val={yesNo(!!d.sessionResumption)} /> | ||
| <Row lbl="OCSP Stapling" val={yesNo(!!d.ocspStapled)} /> | ||
| <Row lbl="OCSP Stapling" val={ocspStatus(!!d.ocspStapled)} /> |
Owner
There was a problem hiding this comment.
If that's only used in one place, can probably just be done inline, instead of a seperate function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TLS Connection card showed ❌ No when OCSP stapling wasn't enabled, which makes it look like a security failure. OCSP stapling is a performance optimization — absence isn't an issue.
Changed the card display from:
Before: ❌ No ✅ Yes
After: Not enabled Yes
No emoji, no red cross. Just factual.
The analysis rule already uses severity: 'info' for this check, so the advisory panel was correct — only the card display was misleading.
Verified with tsc and prettier, both clean.