Skip to content

fix(media): cache remote image dimensions and set timeout #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalahammad wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(media): cache remote image dimensions and set timeout #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 57 additions & 4 deletions src/media.cls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,9 +1135,10 @@ private function _parse_img() {
}

/**
* Detect the original sizes.
* Detect original image dimensions with transient caching for remote URLs.
*
* @since 4.0
* @since 7.9 Added transient caching, Range request, and timeout for remote images.
*
* @param string $src Source URL/path.
* @return array|false getimagesize array or false.
Expand All @@ -1154,16 +1155,68 @@ private function _detect_dimensions( $src ) {
$src = 'https:' . $src;
}

try {
$sizes = getimagesize( $src );
} catch ( \Exception $e ) {
if ( $pathinfo ) {
try {
// phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
$sizes = @getimagesize( $src );
} catch ( \Exception $e ) {
return false;
}

if ( ! empty( $sizes[0] ) && ! empty( $sizes[1] ) ) {
return $sizes;
}

return false;
}

if ( ! function_exists( 'getimagesizefromstring' ) ) {
return false;
}

// Use transient cache to prevent blocking HTTP requests on remote images.
$cache_key = 'lsc_img_sz_' . md5( $src );
$cached = get_transient( $cache_key );
if ( false !== $cached ) {
if ( 'failed' === $cached ) {
return false;
}
return $cached;
}

$response = wp_safe_remote_get(
$src,
[
'timeout' => 2,
'limit_response_size' => 65536,
'user-agent' => 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) LiteSpeedCache/Dimensions',
'headers' => [
'Range' => 'bytes=0-32768',
],
]
);

if ( is_wp_error( $response ) ) {
set_transient( $cache_key, 'failed', HOUR_IN_SECONDS );
return false;
}

$code = (int) wp_remote_retrieve_response_code( $response );
if ( 200 !== $code && 206 !== $code ) {
set_transient( $cache_key, 'failed', HOUR_IN_SECONDS );
return false;
}

$body = wp_remote_retrieve_body( $response );
// phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
$sizes = ! empty( $body ) ? @getimagesizefromstring( $body ) : false;

if ( ! empty( $sizes[0] ) && ! empty( $sizes[1] ) ) {
set_transient( $cache_key, $sizes, 7 * DAY_IN_SECONDS );
return $sizes;
}

set_transient( $cache_key, 'failed', HOUR_IN_SECONDS );
return false;
}

Expand Down
Loading