Add new rtc path and handle legacy server handling #1781
Conversation
🦋 Changeset detectedLatest commit: f66f3d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
boks1971
left a comment
boks1971
left a comment
There was a problem hiding this comment.
have called the old path handler inside server as v0, maybe use that name here also instead of Legacy? But, not too particular.
…k-js into lukas/signalling-paths
size-limit report 📦
|
| case 401: | ||
| case 403: | ||
| const msg = await resp.text(); | ||
| return ConnectionError.notAllowed(msg, resp.status); | ||
| default: | ||
| break; |
There was a problem hiding this comment.
question: The old code looks like it was checking any 4xx error for this case. Is it possible that the validation url could return a 4xx other than 401/403 and should anything happen in that case to keep the preexisting behavior?
There was a problem hiding this comment.
the current codes returned by the validation logic can be seen here https://github.com/livekit/livekit/blob/4104b8270ba8c653f80a27737bd125f06ef0e06d/pkg/service/utils.go#L245-L246
Today there's 400 and 401.
Returning notAllowed for a 400 error doesn't feel quire right. Surfacing the underlying status code instead feels a bit more obvious.
No description provided.