Add participant identity, name, and metadata to root useAgent() return value #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f362b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
davidzhao
approved these changes
Dec 15, 2025
Member
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
lg, just would suggest updating the comment
| failureReasons: null; | ||
|
|
||
| /** The client's assigned identity, coming from the JWT token. */ | ||
| identity: Participant['identity']; |
Member
There was a problem hiding this comment.
is it the agent's identity? or the end-user's identity? the comment seems to be indicating the latter. (i.e. client).
assuming it's the agent's, i'd recommend changing the comment to be clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identityfor interfacing with with existing lower level apis (it looked like his use case was RPC calls)agentParticipant'sidentityon the rootuseAgent()return valueuseParticipantInfo()was returning name + metadata alongside identity, so it seems like all three are probably equally important (especially since all three are exposed inTokenSourceFetchOptions)