[BUG] Does backup_storage actually works?

[yihtserns]

Describe the bug
In https://github.com/livekit/egress#config:

backup_storage: files will be moved here when uploads fail. location must have write access granted for all users

...but:

1. When I configure it e.g. backup_storage: /backup, make recording failed e.g. not starting my local "cloud" storage destination i.e. MinIO, I don't see anything in /backup directory in the Docker container nor any log message that mentioned "backup".
2. I don't see backup_storage in https://github.com/livekit/egress/blob/73e93368e172462909ec4dca2d68b0cfb07a5068/pkg/config/base.go, only backup:

   egress/pkg/config/base.go

   Line 57 in 73e9336

   BackupConfig *StorageConfig `yaml:"backup,omitempty"` // backup config, for storage failures

   .

Egress Version
1.12.0

Egress Request
N/A

Additional context
N/A

Logs
N/A

[milos-lk]

Thanks for the report, the README was out of date. backup_storage was replaced by a backup block in v1.9.0 (#792), which takes the same fields as storage. The old key is silently ignored, which is why nothing happened.

For a local directory:

backup:
  prefix: /backup

/backup must be writable by the egress user. The README fix is in #1414.