standup.sh & teardown.sh for non-cluster-level-admin users #546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem:
The
standup.shandteardown.shscripts cannot be executed successfully by users who do not have cluster-level privileges, even if they have admin permissions in the namespace where they are trying to install the llm-d stack.Changes made:
Added an additional run option via the
--non-adminflag for thesetup.shandteardown.shscripts.This option allows users without cluster-level admin privileges to run and deploy the llm-d stack in a specific namespace (pre-created one).
Detailed explanation of the code changes:
-i|--non-adminflag. When the flag is set, serval default variables are overridden to prevent modification to cluster level resources (the blocking commands).non-adminflag. Changed the default model to the llm-d well-lit-paths default model (I believe the previous default model was a bug? It didn't run successfully).--non-adminflag is set to true, the helmfile yaml now sets thecreateNamespacevariable to false (as non-cluster-admin users are unable to create namespaces).-i|--non-adminflag. When this flag is set, the delete ClusterRole step is skipped.How the PR was tested:
./setup/standup.sh -c "$(pwd)/setup/example_env.sh" --non-adminwhere
example_env.shcontained :The result:
Finally, running:
./setup/teardown.sh -c "$(pwd)/setup/example_env.sh" --non-admin