Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Documentation for developing the inference scheduler.
## Requirements

- [Make] `v4`+
- [Golang] `v1.24`+
- [Golang] `v1.25`+
- [Docker] (or [Podman])
- [Kubernetes in Docker (KIND)]
- [Kustomize]
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.epp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Minimal runtime Dockerfile (microdnf-only, no torch, wrapper in site-packages)
# Build Stage: using Go 1.24 image
FROM quay.io/projectquay/golang:1.24 AS builder
# Build Stage: using Go 1.25 image
FROM quay.io/projectquay/golang:1.25 AS builder

ARG TARGETOS
ARG TARGETARCH
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.sidecar
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build Stage: using Go 1.24 image
FROM quay.io/projectquay/golang:1.24 AS builder
# Build Stage: using Go 1.25 image
FROM quay.io/projectquay/golang:1.25 AS builder
ARG TARGETOS
ARG TARGETARCH
ARG COMMIT_SHA=unknown
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ check-ginkgo:
.PHONY: check-golangci-lint
check-golangci-lint:
@command -v golangci-lint >/dev/null 2>&1 || { \
echo "❌ golangci-lint is not installed. Install from https://golangci-lint.run/usage/install/"; exit 1; }
echo "❌ golangci-lint is not installed. Install from https://golangci-lint.run/docs/welcome/install/"; exit 1; }

.PHONY: check-kustomize
check-kustomize:
Expand Down
4 changes: 1 addition & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module github.com/llm-d/llm-d-inference-scheduler

go 1.24.1

toolchain go1.24.2
go 1.25

require (
github.com/go-logr/logr v1.4.3
Expand Down
4 changes: 2 additions & 2 deletions pkg/sidecar/proxy/data_parallel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (

"github.com/llm-d/llm-d-inference-scheduler/pkg/common"
sidecarmock "github.com/llm-d/llm-d-inference-scheduler/test/sidecar/mock"
testutils "github.com/llm-d/llm-d-inference-scheduler/test/utils"
"github.com/llm-d/llm-d-inference-scheduler/test/testnet"
)

const (
Expand All @@ -30,7 +30,7 @@ var _ = Describe("Data Parallel support", func() {
// proxy.startDataParallel starts listeners on the ports following
// the proxy's main port. To avoid problems, get a free port and
// tell the proxy that it is listening on that port minus one.
freePort, err := testutils.GetFreePort()
freePort, err := testnet.GetFreePort()
Expect(err).ToNot(HaveOccurred())
tmpPort, err := strconv.Atoi(freePort)
fakeProxyPort := tmpPort - 1
Expand Down
5 changes: 3 additions & 2 deletions test/e2e/e2e_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,11 @@ func createInferencePool(numTargetPorts int, toDelete bool) []string {
}

infPoolYaml := testutils.ReadYaml(inferExtManifest)
targetPorts := ""
var targetPortsBuilder strings.Builder
for idx := range numTargetPorts {
targetPorts += fmt.Sprintf("\n - number: %d", 8000+idx)
targetPortsBuilder.WriteString(fmt.Sprintf("\n - number: %d", 8000+idx))
}
targetPorts := targetPortsBuilder.String()
infPoolYaml = substituteMany(infPoolYaml,
map[string]string{
"${POOL_NAME}": poolName,
Expand Down
6 changes: 2 additions & 4 deletions test/utils/network.go → test/testnet/network.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Package utils contains utilities for testing
//
//revive:disable:var-naming
package utils
// Package testnet contains network utilities for testing
package testnet

//revive:enable:var-naming

Expand Down
Loading