Add SubView class - #1915
Open
gberg617 wants to merge 31 commits into
Open
Conversation
gberg617
marked this pull request as draft
September 19, 2025 21:12
Contributor
Author
|
This PR is still a WIP! |
MrBurmark
reviewed
Sep 19, 2025
MrBurmark
reviewed
Sep 19, 2025
MrBurmark
reviewed
Sep 19, 2025
MrBurmark
reviewed
Sep 19, 2025
gberg617
force-pushed
the
feature/bergel1/subview
branch
from
September 30, 2025 01:08
804abcd to
5ba920d
Compare
gberg617
commented
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Sep 30, 2025
MrBurmark
reviewed
Oct 2, 2025
rcarson3
reviewed
Oct 2, 2025
Contributor
Author
|
I'm considering separating the SubView holding the view from the slices that are used to access the view, somewhat analogous to the approach of having layouts and Views be separate classes. Any thoughts on this? |
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
MrBurmark
reviewed
Oct 11, 2025
…pen interval [start, end) and added more checks for StridedSlice size
…assert to SubRegion
…ith projected dimensions
2. Replaced camp::array usage with std::array. 3. Fixed and simplified get_dim_stride and get_parent_dim_stride. 4. Replaced usage of IndexType with size_t where appropriate.
gberg617
force-pushed
the
feature/bergel1/subview
branch
from
July 22, 2026 17:23
91eca15 to
2442033
Compare
gberg617
commented
Jul 22, 2026
| @@ -26,6 +26,9 @@ | |||
| #include <type_traits> | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
I need to fix this rebased file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A few simple examples are provided below:
Here,
sv1andsv2are subviews of dimensions(2,3)and(2)respectively.Future tasks: