Skip to content

Energy mortar cleanup - #207

Merged
ebchin merged 19 commits into
developfrom
new-mortar-cleanup
Jul 9, 2026
Merged

Energy mortar cleanup#207
ebchin merged 19 commits into
developfrom
new-mortar-cleanup

Conversation

@ebchin

@ebchin ebchin commented May 20, 2026

Copy link
Copy Markdown
Member
  • Removed .clangd as it was build specific
  • Clean up coupling scheme and mfem_tribol logic
  • Clean up tests (single registration of coupling scheme instead of per-timestep, remove formulation_ready in tribol_energy_mortar_patch_LM). Needed a method to update penalty parameters in ContactFormulation to support this.
  • Add a getMfemJacobian() method to return a single mfem::HypreParMatrix (no blocks) for penalty methods

Comment thread src/tests/tribol_energy_mortar_patch.cpp
Comment thread src/tests/tribol_energy_mortar_patch.cpp Outdated
Comment thread src/shared/mesh/MeshBuilder.cpp Outdated
Comment thread src/tests/tribol_energy_mortar_patch.cpp Outdated
Comment thread src/tests/tribol_energy_mortar_patch_LM.cpp
Comment thread src/tribol/mesh/CouplingScheme.cpp
Comment thread src/tribol/mesh/CouplingScheme.cpp
Comment thread src/tribol/mesh/MfemData.hpp
Comment thread src/tribol/physics/ContactFormulation.hpp Outdated
Comment thread src/tribol/physics/ContactFormulationFactory.cpp

@srwopschall srwopschall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebchin - We discussed most everything I wanted to discuss. The rest of the comments are self-explanatory in terms of what might need to be modified.

Comment thread src/shared/mesh/MeshBuilder.cpp Outdated
Comment thread src/tribol/interface/mfem_tribol.cpp Outdated
@chapman39 chapman39 mentioned this pull request Jul 6, 2026

@srwopschall srwopschall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the getMfemJacobian() vs. getMfemDfDx() comments.

@ebchin
ebchin merged commit 4e33a12 into develop Jul 9, 2026
14 checks passed
@ebchin
ebchin deleted the new-mortar-cleanup branch July 9, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants